Skip to content

Comments

[WIP] Generate the all-in-one manifest#509

Closed
tenzen-y wants to merge 1 commit intokubeflow:masterfrom
tenzen-y:generate-manifests
Closed

[WIP] Generate the all-in-one manifest#509
tenzen-y wants to merge 1 commit intokubeflow:masterfrom
tenzen-y:generate-manifests

Conversation

@tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jan 26, 2023 •
edited
Loading

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

I forgot to re-generate deploy/v2beta1/mpi-operator.yaml when I upgraded the kubernetes dependencies.
So I re-generate that manifest with kustomize build manifests/overlays/standalone/.

Fixes: #508

@tenzen-y
Generate the all-in-one manifest
3c34a1d 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@google-oss-prow
Copy link

google-oss-prow bot commented Jan 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rongou for approval by writing /assign @rongou in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested review from gaocegege and zw0610 January 26, 2023 22:27
terrytangyuan
terrytangyuan reviewed Jan 26, 2023
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a diff check in the CI?

@tenzen-y
Copy link
Member Author

tenzen-y commented Jan 27, 2023

Could we add a diff check in the CI?

Makes sense. Yes, sure.

@tenzen-y
Copy link
Member Author

tenzen-y commented Jan 27, 2023

Blocked by #510

@tenzen-y tenzen-y changed the title Generate the all-in-one manifest [WIP] Generate the all-in-one manifest Jan 27, 2023
@tenzen-y tenzen-y mentioned this pull request Jan 30, 2023
Merged
@tenzen-y
Copy link
Member Author

tenzen-y commented Jan 30, 2023

I include these changes in #510.

/close

@google-oss-prow google-oss-prow bot closed this Jan 30, 2023
@google-oss-prow
Copy link

google-oss-prow bot commented Jan 30, 2023

@tenzen-y: Closed this PR.

Details

In response to this:

I include these changes in #510.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tenzen-y tenzen-y deleted the generate-manifests branch January 30, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@gaocegege gaocegege Awaiting requested review from gaocegege

@zw0610 zw0610 Awaiting requested review from zw0610

Assignees

No one assigned

Labels

do-not-merge/work-in-progress size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need to add "coordination.k8s.io" and "-leases" to clusterrole

2 participants

@tenzen-y @terrytangyuan